Repository navigation
Core: Add delete_files for removing data files by path - #4459
Open
Anurag-S1ngh wants to merge 2 commits into
Open
Anurag-S1ngh wants to merge 2 commits into
Anurag-S1ngh wants to merge 2 commits into
Conversation
Tables can add existing data files but had no way to remove them, which is the remaining gap with Java DeleteFiles. Add Table.delete_files and Transaction.delete_files taking full file paths, validating that each path is unique and still referenced by the target branch, and committing a copy-on-write delete snapshot with optional properties.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tables can add existing data files with
add_files, but there was no way to remove them without rewriting the table. Java exposesDeleteFilesfor this, and PyIceberg had no equivalent.Add
Table.delete_filesandTransaction.delete_files, taking the full paths of live data files. Each path must be unique and referenced by the target branch. The call commits a copy-on-write delete snapshot and accepts snapshot properties and a branch, mirroringadd_files.Are these changes tested?
Yes. Unit tests remove files and check the remaining rows and snapshot properties, and cover duplicate paths and paths that are not referenced.
tests/tablepasses.Are there any user-facing changes?
Yes. A new
delete_filesAPI is available on tables and transactions.